dstandish commented on code in PR #51805:
URL: https://github.com/apache/airflow/pull/51805#discussion_r2167189019
##########
airflow-core/src/airflow/utils/task_group.py:
##########
@@ -94,3 +94,44 @@ def task_group_to_dict(task_item_or_group,
parent_group_is_mapped=False):
"children": children,
"type": "task",
}
+
+
+def task_group_to_dict_grid(task_item_or_group, parent_group_is_mapped=False):
Review Comment:
they are similar but the other one does something different re children....
you could DRY it up just a bit but it would add a little complexity.
Personally i think it's better to avoid the coupling and just let the logic be
independent for the diff use case. It's just an internal helper function that
retrieves the info needed for the _grid_ use case as opposed to the _graph_ use
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
