amoghrajesh commented on PR #52129:
URL: https://github.com/apache/airflow/pull/52129#issuecomment-3003667052

   > This is fine, but, we should make the tests work without the DB and remove 
all "db_test" markers for them eventually,
   
   Yep! That is my goal too
   
   > If I understand correctly - you now create both DB and ENV vars, so it 
should be just a matter of running conditional code to "only" clear and set 
"env variables" when DB is not available in the common pytest plugin code. The 
common plugin code already works fine when there is no DB - but I think what it 
does it will skip creation of the default connections - but if you **just** 
change the common code to skip all DB parts but only set the env vars, then I 
belive none of the "get_connection" calls should even try to make a DB call and 
they should simply **work** when you set `--backend none`
   
   @potiuk quite the opposite actually, i have extracted out logic to not 
create stuff on DB for tests. (Trying to get to complete coverage). 
   
   Right now, for tests, it creates only default connections and regular 
connections on ENV only.
   
   That is precisely what you propose I believe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to