ashb commented on code in PR #50371:
URL: https://github.com/apache/airflow/pull/50371#discussion_r2166132776
##########
airflow-core/tests/unit/dag_processing/test_processor.py:
##########
@@ -78,6 +79,11 @@ def inprocess_client():
return client
[email protected]
+def mock_logger():
Review Comment:
This fixture doesn't add anything over using mock directly
##########
airflow-core/tests/unit/dag_processing/test_processor.py:
##########
@@ -158,6 +169,7 @@ def dag_in_a_fn():
path=path,
bundle_path=tmp_path,
callbacks=[],
+ logger=mock_logger,
Review Comment:
Do we need this change? I thought there was already a logger attribute on
the class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
