Copilot commented on code in PR #52231:
URL: https://github.com/apache/airflow/pull/52231#discussion_r2166345089


##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1599,6 +1600,7 @@ def _create_dag_runs_asset_triggered(
                     AssetEvent.timestamp <= triggered_date,
                     AssetEvent.timestamp > 
func.coalesce(cte.c.previous_dag_run_run_after, date.min),
                 )
+                .order_by(AssetEvent.timestamp.asc())

Review Comment:
   [nitpick] Consider adding a secondary ordering (e.g., `AssetEvent.id`) to 
the query to guarantee deterministic ordering when multiple events share the 
same timestamp.
   ```suggestion
                   .order_by(AssetEvent.timestamp.asc(), AssetEvent.id.asc())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to