tanujdargan opened a new pull request, #52408:
URL: https://github.com/apache/airflow/pull/52408
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
### Fixes: [#51299](https://github.com/apache/airflow/issues/51299) -
Impossible to load UI if user does not have read permissions on plugins
#### Summary
This PR ensures the Airflow UI loads gracefully for authenticated users who
do not have read permissions on plugins.
#### Details
- Updated approach to work following #51889 merge.
- Refactored `routes/ui/config.py` to safely handle cases where
`plugins_manager.flask_appbuilder_menu_links` is `None`, preventing 403 errors
from blocking the UI.
- Adjusted import order for clarity and maintainability.
- The UI now loads extra plugin menu items from a new
`plugins_extra_menu_items` attribute in the UI config endpoint, so all
authenticated users can see them, regardless of direct plugin permissions.
- The UI no longer calls the `public/providers` endpoint for these menu
items.
- Fixes failing CI pipeline and other tests.
#### Context
Previously, users without read permissions on plugins would receive a 403
Forbidden error, causing the entire UI to fail rendering. With this fix, the UI
continues to render and display default elements, and plugin menu items are
provided in a way accessible to all authenticated users.
---
Closes #51299.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
