SCH227 opened a new pull request, #52419: URL: https://github.com/apache/airflow/pull/52419
In `FabAirflowSecurityManagerOverride.reset_user_sessions()` two warning strings are built with an f-string that embeds `user.username`. Each string is passed to `_cli_safe_flash()`, which does `flash(Markup(text), level)`. `Markup()` tells Flask not to escape anything. https://github.com/apache/airflow/blob/262cd8167da107618c3d3e5d7057530b5be3236b/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py#L549-L552 https://github.com/apache/airflow/blob/262cd8167da107618c3d3e5d7057530b5be3236b/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py#L2384-L2387 The code changes aim to prevent a theoretical XSS attack vector, even though, as pointed out by Airflow Security team, Airflow users have no influence on the username -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
