Copilot commented on code in PR #52518:
URL: https://github.com/apache/airflow/pull/52518#discussion_r2174506750


##########
airflow-core/src/airflow/models/base.py:
##########
@@ -52,6 +53,10 @@ def _get_schema():
     Base = Any
 else:
     Base = mapper_registry.generate_base()
+    # TEMPORARY workaround to allow using unmapped (v1.4) models in SQLAlchemy 
2.0. It is intended only to
+    # unblock the development of SQLA2 support.

Review Comment:
   [nitpick] The temporary workaround using Base.__allow_unmapped__ is a useful 
interim solution but should be clearly documented with a TODO or similar note 
to revisit once full SQLAlchemy 2.0 support is complete.
   ```suggestion
       # unblock the development of SQLA2 support.
       # TODO: Remove this workaround once full SQLAlchemy 2.0 support is 
implemented.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to