dominikhei commented on code in PR #51756:
URL: https://github.com/apache/airflow/pull/51756#discussion_r2175040989
##########
providers/tableau/docs/connections/tableau.rst:
##########
@@ -35,6 +35,12 @@ There are two ways to connect to Tableau using Airflow.
2. Use a `Token Authentication
<https://tableau.github.io/server-client-python/docs/api-ref#personalaccesstokenauth-class>`_
i.e. add a ``token_name`` and ``personal_access_token`` to the Airflow
connection (deprecated).
+3. Use `JSON Web Token (JWT) Authentication
+
<https://tableau.github.io/server-client-python/docs/sign-in-out.html#sign-in-with-json-web-token-jwt>`_
+ i.e add a ``jwt_file`` or a ``jwt_token`` to the Airflow connection extras.
+
+If both Password and Username authentication and JWT authentication are used
simultaneously,
+Password and Username authentication is preferred.
Review Comment:
@eladkal I’ve updated the behavior to raise an error when both
authentication methods are configured. However, the [Trino
provider](https://github.com/apache/airflow/blob/main/providers/trino/src/airflow/providers/trino/hooks/trino.py#L153)
allows the same behavior:
Jwt and password auth can be set simultaneously, but password is silently
preferred. Moreover it raises an error if cert / kerberos auth and a password
is set.
For consistency, should we consider updating it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
