jedcunningham commented on code in PR #52388:
URL: https://github.com/apache/airflow/pull/52388#discussion_r2176291113
##########
chart/templates/_helpers.yaml:
##########
@@ -216,6 +216,34 @@ If release name contains chart name it will be used as a
full name.
defaultMode: 288
{{- end }}
+{{/* Helper to render git-sync credentials envs for v3/v4 */}}
+{{- define "git_sync.env_credentials" }}
+{{- $tag := .Values.images.gitSync.tag | default "v4" }}
Review Comment:
We can't rely on the tag for this - we need to support folks who have
mirrored the image and changed the tag names. If we want to add conditional
logic, we will need to add a new version field for gitsync.
Also, we will want a significant newsfragment for this - this is bordering a
breaking change and will want to make sure we message it appropriately.
Maybe we default the version to none and add both in that case, and only the
right ones if the version is set? That's non breaking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
