(airflow) branch main updated: Improve plugins menu items (#52719)

[pierrejeambrun]

This is an automated email from the ASF dual-hosted git repository.

pierrejeambrun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new eceecff8f92 Improve plugins menu items (#52719)
eceecff8f92 is described below

commit eceecff8f922159464304db213a466233350c23a
Author: Pierre Jeambrun <pierrejb...@gmail.com>
AuthorDate: Wed Jul 2 18:09:12 2025 +0200

    Improve plugins menu items (#52719)
---
 .../airflow/ui/src/layouts/Nav/PluginMenuItem.tsx  | 29 ++++++++++++----------
 .../src/airflow/ui/src/layouts/Nav/PluginMenus.tsx |  4 +--
 2 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx 
b/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx
index eb298ded06c..c9d0d041310 100644
--- a/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx
+++ b/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx
@@ -45,11 +45,12 @@ export const PluginMenuItem = ({ href, icon, name, topLevel 
= false, url_route:
         to={href}
       />
     ) : (
-      <Box alignItems="center" display="flex" gap={2} outline="none" px={2} 
py="6px">
+      <Box alignItems="center" display="flex" width="100%">
         <Link
           aria-label={name}
           fontSize="sm"
           href={href}
+          outline="none"
           rel="noopener noreferrer"
           target="_blank"
           width="100%"
@@ -79,17 +80,19 @@ export const PluginMenuItem = ({ href, icon, name, topLevel 
= false, url_route:
   }
 
   return (
-    <RouterLink to={`plugin/${urlRoute}`}>
-      <Box alignItems="center" display="flex" fontSize="sm" gap={2} px={2} 
py="6px">
-        {typeof icon === "string" ? (
-          <Image height="1.25rem" src={icon} width="1.25rem" />
-        ) : urlRoute === "legacy-fab-views" ? (
-          <RiArchiveStackLine size="1.25rem" />
-        ) : (
-          <LuPlug size="1.25rem" />
-        )}
-        {name}
-      </Box>
-    </RouterLink>
+    <Box width="100%">
+      <RouterLink style={{ outline: "none" }} to={`plugin/${urlRoute}`}>
+        <Box alignItems="center" display="flex" fontSize="sm">
+          {typeof icon === "string" ? (
+            <Image height="1.25rem" src={icon} width="1.25rem" />
+          ) : urlRoute === "legacy-fab-views" ? (
+            <RiArchiveStackLine size="1.25rem" />
+          ) : (
+            <LuPlug size="1.25rem" />
+          )}
+          {name}
+        </Box>
+      </RouterLink>
+    </Box>
   );
 };
diff --git a/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenus.tsx 
b/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenus.tsx
index d8850f9ec1e..f853fad75f5 100644
--- a/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenus.tsx
+++ b/airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenus.tsx
@@ -92,7 +92,7 @@ export const PluginMenus = () => {
           </Menu.Trigger>
           <Menu.Content>
             {buttons.map((externalView) => (
-              <Menu.Item asChild key={externalView.name} 
value={externalView.name}>
+              <Menu.Item key={externalView.name} value={externalView.name}>
                 <PluginMenuItem {...externalView} />
               </Menu.Item>
             ))}
@@ -104,7 +104,7 @@ export const PluginMenus = () => {
                 </Menu.TriggerItem>
                 <Menu.Content>
                   {menuButtons.map((externalView) => (
-                    <Menu.Item asChild key={externalView.name} 
value={externalView.name}>
+                    <Menu.Item key={externalView.name} 
value={externalView.name}>
                       <PluginMenuItem {...externalView} />
                     </Menu.Item>
                   ))}