Fokko commented on a change in pull request #6461: [AIRFLOW-5804] Batch the
xcom pull operation
URL: https://github.com/apache/airflow/pull/6461#discussion_r341119840
##########
File path: tests/models/test_taskinstance.py
##########
@@ -869,7 +869,7 @@ def test_xcom_pull(self):
# Pull the values pushed by both tasks
result = ti1.xcom_pull(
task_ids=['test_xcom_1', 'test_xcom_2'], key='foo')
- self.assertEqual(result, ('bar', 'baz'))
+ self.assertEqual(result, ['baz', 'bar'])
Review comment:
Thanks @ashb for reviewing. Appreciate it.
I've updated this test because it was passing before, but it was actually
invalid. The `xcom_pull` would invoke the `XCom.get_one()` many times, and
transform it into an iterable. Therefore ordering would be lost. Now we get the
xcom's descending by execution_date, insertion_date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
