bugraoz93 commented on code in PR #52713:
URL: https://github.com/apache/airflow/pull/52713#discussion_r2183204096
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py:
##########
@@ -38,6 +38,7 @@ class ConnectionResponse(BaseModel):
port: int | None
password: str | None
extra: str | None
+ description: str | None = Field(default=None, description="Connection
description")
Review Comment:
Thanks @nrnavaneet for your first PR! There is already a description field
in line 34. If you want to include `Field description`, feel free, but since
the field is `str | None`, it should also default to None automatically, so I
don't think the `default=None` part is needed in this context.
https://github.com/apache/airflow/blob/6c4d88411ad9f96f8213256a5126d7e185749366/airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py#L34
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
