jscheffl commented on code in PR #52795:
URL: https://github.com/apache/airflow/pull/52795#discussion_r2183723179
##########
airflow-core/src/airflow/ui/src/pages/Run/Run.tsx:
##########
@@ -32,12 +33,16 @@ export const Run = () => {
const { t: translate } = useTranslation("dag");
const { dagId = "", runId = "" } = useParams();
+ // Get external views with dag_run destination
+ const externalTabs = usePluginTabs("dag_run");
+
const tabs = [
{ icon: <MdOutlineTask />, label: translate("tabs.taskInstances"), value:
"" },
{ icon: <FiDatabase />, label: translate("tabs.assetEvents"), value:
"asset_events" },
{ icon: <MdOutlineEventNote />, label: translate("tabs.auditLog"), value:
"events" },
{ icon: <FiCode />, label: translate("tabs.code"), value: "code" },
{ icon: <MdDetails />, label: translate("tabs.details"), value: "details"
},
+ ...externalTabs,
Review Comment:
Never thought about this before... but would we put plugins always to back
or to front?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
