mik-laj commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S 
worker pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r341334482
 
 

 ##########
 File path: airflow/kubernetes/worker_configuration.py
 ##########
 @@ -361,22 +365,15 @@ def generate_dag_volume_mount_path(self) -> str:
 
         return self.kube_config.git_dags_folder_mount_point
 
-    def make_pod(self, namespace, worker_uuid, pod_id, dag_id, task_id, 
execution_date,
-                 try_number, airflow_command) -> k8s.V1Pod:
-        """Creates POD."""
-        pod_generator = PodGenerator(
-            namespace=namespace,
-            name=pod_id,
+    def make_pod(self) -> k8s.V1Pod:
+        """
+        :return: kubernetes.client.models.V1Pod
+
+        Parses the airflow.cfg and returns the Pod configuration generated 
from it.
 
 Review comment:
   ```suggestion
           Parses the airflow.cfg and returns the Pod configuration generated 
from it.
           
           :rtype: kubernetes.client.models.V1Pod
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to