potiuk opened a new pull request, #52867:
URL: https://github.com/apache/airflow/pull/52867
There were a couple of problems that prevented the SBOM generation to
successfully run in our workflows:
* remote_name was hard-coded to "apache" for locally pulling tags from the
right remote - and we did not have that remote in CI
* python parameter was set by default to "default_python_version" in CI, and
what we really wanted is to have it empty to use all historical versions of
python
* generating SBOMs used the "ref" version of breeze rather than "current PR
version" of breeze.
* python version installed was the default python version that was used in
the "reference" of built docs - not the "current" default version - which made
it impossible to reinstall breeze to current version when old version of Python
was not supported any more
* When RC version SBOM was generated, it did not use RC constraints and tags
so, all SBOMS were silently skipped.
This is fixed by:
* you can now pass remote-name as option
* historical_python_versions click option now uses --python-versions and
PYTHON_VERSIONS envvar and can take list of versions separated by comas - to
not confuse it with regular --python option
* switching temporarily to the "current-version" of breeze when generating
SBOM
* we are installing breeze with "current" default python version - assuming
that this version will be supported by any versions of packages we want to
build the documentation for
* when RC version is passed as ref, we are using RC version of constraints
and tags but we still produce sboms for "base" version - matching the way how
documentation is done.
(cherry picked from commit 554fbc61b27a558ef83950a36900841b2866ec36)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
