This is an automated email from the ASF dual-hosted git repository. amoghdesai pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push: new 597bbde137a Replace BaseHook to Task SDK for apache/pinot (#52841) 597bbde137a is described below commit 597bbde137aebb3a031aa71f4313b49de486dc4e Author: Dov Benyomin Sohacheski <b@kloud.email> AuthorDate: Sat Jul 5 08:11:58 2025 +0300 Replace BaseHook to Task SDK for apache/pinot (#52841) --- .../airflow/providers/apache/pinot/hooks/pinot.py | 6 +-- .../providers/apache/pinot/version_compat.py | 45 ++++++++++++++++++++++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/providers/apache/pinot/src/airflow/providers/apache/pinot/hooks/pinot.py b/providers/apache/pinot/src/airflow/providers/apache/pinot/hooks/pinot.py index c27612b6d33..f0a11fc37ec 100644 --- a/providers/apache/pinot/src/airflow/providers/apache/pinot/hooks/pinot.py +++ b/providers/apache/pinot/src/airflow/providers/apache/pinot/hooks/pinot.py @@ -26,13 +26,9 @@ from urllib.parse import quote_plus from pinotdb import connect from airflow.exceptions import AirflowException +from airflow.providers.apache.pinot.version_compat import BaseHook from airflow.providers.common.sql.hooks.sql import DbApiHook -try: - from airflow.sdk import BaseHook -except ImportError: - from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef] - if TYPE_CHECKING: from airflow.models import Connection diff --git a/providers/apache/pinot/src/airflow/providers/apache/pinot/version_compat.py b/providers/apache/pinot/src/airflow/providers/apache/pinot/version_compat.py new file mode 100644 index 00000000000..a525254fd99 --- /dev/null +++ b/providers/apache/pinot/src/airflow/providers/apache/pinot/version_compat.py @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# NOTE! THIS FILE IS COPIED MANUALLY IN OTHER PROVIDERS DELIBERATELY TO AVOID ADDING UNNECESSARY +# DEPENDENCIES BETWEEN PROVIDERS. IF YOU WANT TO ADD CONDITIONAL CODE IN YOUR PROVIDER THAT DEPENDS +# ON AIRFLOW VERSION, PLEASE COPY THIS FILE TO THE ROOT PACKAGE OF YOUR PROVIDER AND IMPORT +# THOSE CONSTANTS FROM IT RATHER THAN IMPORTING THEM FROM ANOTHER PROVIDER OR TEST CODE +# +from __future__ import annotations + + +def get_base_airflow_version_tuple() -> tuple[int, int, int]: + from packaging.version import Version + + from airflow import __version__ + + airflow_version = Version(__version__) + return airflow_version.major, airflow_version.minor, airflow_version.micro + + +AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0) + +if AIRFLOW_V_3_1_PLUS: + from airflow.sdk import BaseHook +else: + from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef] + +__all__ = [ + "AIRFLOW_V_3_1_PLUS", + "BaseHook", +]