aritra24 commented on code in PR #52265:
URL: https://github.com/apache/airflow/pull/52265#discussion_r2186878941
##########
Dockerfile.ci:
##########
@@ -1279,8 +1308,14 @@ ENV DEV_APT_COMMAND=${DEV_APT_COMMAND} \
ADDITIONAL_DEV_APT_DEPS=${ADDITIONAL_DEV_APT_DEPS} \
ADDITIONAL_DEV_APT_COMMAND=${ADDITIONAL_DEV_APT_COMMAND}
-COPY --from=scripts install_os_dependencies.sh /scripts/docker/
-RUN bash /scripts/docker/install_os_dependencies.sh dev
+ARG AIRFLOW_PYTHON_VERSION=v3.10.18
+ARG GOLANG_MAJOR_MINOR_VERSION=1.24.4
+
+COPY --from=scripts install_os_dependencies_ci.sh /scripts/docker/
+
+RUN AIRFLOW_PYTHON_VERSION=$AIRFLOW_PYTHON_VERSION \
+ GOLANG_MAJOR_MINOR_VERSION=${GOLANG_MAJOR_MINOR_VERSION} \
+ bash /scripts/docker/install_os_dependencies_ci.sh ci
Review Comment:
One minor note here, I had to pass the args explicitly into the run command
because without them the layers weren't getting invalidated since docker tries
to be smart that way to reduce unnecessary builds.
cc: @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
