jedcunningham commented on code in PR #52977:
URL: https://github.com/apache/airflow/pull/52977#discussion_r2191028786
##########
helm-tests/tests/helm_tests/security/test_fernetkey_secret.py:
##########
@@ -26,11 +29,24 @@ class TestFernetKeySecret:
def test_should_add_annotations_to_fernetkey_secret(self):
docs = render_chart(
values={
- "fernetKey": "test",
+ "fernetKey": "0IElBVJmqYRvIXEed4711qEHLkeNl8uJ1q1EmnrKDUg=",
Review Comment:
Why are we changing this one?
##########
chart/templates/secrets/fernetkey-secret.yaml:
##########
@@ -21,10 +21,12 @@
## Airflow Fernet Key Secret
#################################
{{- if not .Values.fernetKeySecretName }}
+# Fernet key value must be b64enc
+{{- $generated_fernet_key := (randAlphaNum 32 | b64enc) }}
apiVersion: v1
kind: Secret
metadata:
- name: {{ .Release.Name }}-fernet-key
+ name: {{ include "airflow.fullname" . }}-fernet-key
Review Comment:
I don't think we can change this since it's a pre-install hook. Can you
remove this and we can discuss/look at it in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
