uranusjr commented on code in PR #52234:
URL: https://github.com/apache/airflow/pull/52234#discussion_r2191491897


##########
airflow-core/src/airflow/models/renderedtifields.py:
##########
@@ -49,9 +49,10 @@
 
     from airflow.models.taskinstance import TaskInstance, TaskInstanceKey
     from airflow.sdk.types import Operator
+    from airflow.serialization.serialized_objects import SerializedBaseOperator
 
 
-def get_serialized_template_fields(task: Operator):
+def get_serialized_template_fields(task: Operator | SerializedBaseOperator):

Review Comment:
   The goal ultimately is to have two BaseOperator-MappedOperator pairs, one in 
the sdk, th other in the scheduler. Each function, depending on what it is for, 
should only receive/return one pair or the other. The scheduler pair will be 
created later after MappedOperator is split like the BaseOperator, but I don’t 
feel we should have a common base for Operator (this is for the sdk pair) and 
SerializedOperator (used in core).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to