jason810496 commented on PR #52839: URL: https://github.com/apache/airflow/pull/52839#issuecomment-3048313205
> And its type is checked again when it is used as a parameter. Is it ok? I think it might cause redundancy and inefficiency. If it is redundant, which type annotation should I remove? I think the `ruff` linter will raise error if we add type annotation on both side. ( No sure, maybe I am wrong ) IMO, adding type annotation at parameters level should be enough. > Do I need to give a fake value to BulkStateFetcher in the test? I prefer to add mock value to `BulkStateFetcher` in the test, as we always provide sync_parallelism in our real use. Thanks for pointing out the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
