potiuk commented on code in PR #53182:
URL: https://github.com/apache/airflow/pull/53182#discussion_r2201025397
##########
providers/google/src/airflow/providers/google/cloud/operators/vertex_ai/ray.py:
##########
@@ -136,9 +138,9 @@ class CreateRayClusterOperator(RayBaseOperator):
def __init__(
self,
+ python_version: str,
+ ray_version: Literal["2.9.3", "2.33", "2.42"],
Review Comment:
But it's ray version for vertex_ai operator - which is specific to google
service that is run there. I don't think it has a lot of problems potential -
because basically what it is doing is it runs ray remotely on vertex-ai.
I think the "ray" part imported localy is mostly to use some constants. We
have similar things in Apache Beam whe for example we can use older python
version to be used when starting a dataproc job.
Similarly - you can often use latest kubernetes client to interface with
older k8s versoin (this is what we actually do - we use k8s python client
"kubernetes>=32.0.0,<33.0.0", and we support k8s "v1.30.10", "v1.31.6",
"v1.32.3", "v1.33.0"
If google team is ok and confirm that it works - I have completely no
problem with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
