potiuk commented on PR #53207:
URL: https://github.com/apache/airflow/pull/53207#issuecomment-3064718939
> Thanks for the fix, Pavan! We may need to add the full test label to run
the failed task in the CI. Upgrade Check skipped in the CI
Upgrade check only runs in "canary" by design.
However there is something wrong because we should only "fail" upgrade check
when Python, PIP, pre-commit, or Node changes - we should not fail when UV and
GOLANG changes. So something is wrong in the upgrade script:
```
# For UV we are not failing the upgrade installers check if it is
updated because
# it is upgraded very frequently, so we want to manually upgrade it
rather than
# get notified about it - until it stabilizes in 1.* version
- name: "Run automated upgrade for uv (not failing - just
informational)"
run: >
pre-commit run
--all-files --show-diff-on-failure --color always --verbose
--hook-stage manual update-installers-and-pre-commit || true
if: always()
env:
UPGRADE_UV: "true"
UPGRADE_PYTHON: "false"
UPGRADE_GOLANG: "true"
UPGRADE_PIP: "false"
UPGRADE_PRE_COMMIT: "false"
UPGRADE_NODE_LTS: "false"
- name: "Run automated upgrade for pip, pre-commit and node (failing
if needed)"
run: >
pre-commit run
--all-files --show-diff-on-failure --color always --verbose
--hook-stage manual update-installers-and-pre-commit
if: always()
env:
UPGRADE_UV: "false"
UPGRADE_PYTHON: "true"
UPGRADE_GOLANG: "false"
UPGRADE_PIP: "true"
UPGRADE_PRE_COMMIT: "true"
UPGRADE_NODE_LTS: "true"
```
The approach we have that we do not want to fail canary build with upgrade
check too often - an only when important things change - so we have two upgrade
checks running - one will not fail (see || true at the end) - it will just
print what needs to be upgraded) when uv, golang need upgrade, the other will
fail when Python or PIP changes.
Then when we run `update-installers-and-pre-commit` - by default it will
upgrade everything anyway - so result is that we anyhow upgrade everything when
either Python or PIP changes or when we manually run the script when we want to
speed up the upgrades of uv for example.
So ... for some reason it failed not as intended as only UV and GOLANG
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
