gopidesupavan commented on code in PR #53302:
URL: https://github.com/apache/airflow/pull/53302#discussion_r2205786967
##########
providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -1047,9 +1048,10 @@ def _get_pandas_df( # type: ignore
df = pd.DataFrame(res["data"], columns=[c[0] for c in res["header"]],
**kwargs)
return df
- def _get_polars_df( # type: ignore
+ def _get_polars_df(
self,
- sql: str,
+ sql,
+ parameters: list[Any] | tuple[Any, ...] | Mapping[str, Any] | None =
None,
Review Comment:
i just looked at it seems super class has this signature and mypy is not
happy when it scans whole providers. thats fine you can follow the same
signature then,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
