sjyangkevin commented on code in PR #51511:
URL: https://github.com/apache/airflow/pull/51511#discussion_r2207593946


##########
airflow-core/tests/unit/dag_processing/test_collection.py:
##########
@@ -492,6 +493,120 @@ def test_serialized_dag_errors_are_import_errors(
         assert len(dag_import_error_listener.existing) == 0
         assert dag_import_error_listener.new["abc.py"] == 
import_error.stacktrace
 
+    @patch.object(ParseImportError, "full_file_path")
+    @pytest.mark.skipif(
+        condition="FabAuthManager" not in conf.get("core", "auth_manager"),
+        reason="This is only for FabAuthManager. Please set the environment 
variable `AIRFLOW__CORE__AUTH_MANAGER` to 
`airflow.providers.fab.auth_manager.fab_auth_manager.FabAuthManager` in 
`files/airflow-breeze-config/environment_variables.env` before running breeze 
shell. To run the test, add the flag `--keep-env-variables` to the pytest 
command.",
+    )

Review Comment:
   I was planning to make this refactor in the past week but didn’t have the 
bandwidth, will push changes probably by end of the week



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to