jscheffl commented on code in PR #53431:
URL: https://github.com/apache/airflow/pull/53431#discussion_r2211201358
##########
providers/standard/src/airflow/providers/standard/utils/python_virtualenv.py:
##########
@@ -67,8 +64,6 @@ def _generate_uv_cmd(tmp_dir: str, python_bin: str,
system_site_packages: bool)
def _generate_venv_cmd(tmp_dir: str, python_bin: str, system_site_packages:
bool) -> list[str]:
"""We are using venv command instead of venv module to allow creation of
venv for different python versions."""
- if python_bin is None:
- python_bin = sys.executable
Review Comment:
I checked all usages in the codebase and from interface and existing use the
python_bin is everywhere consistently used. If user would not pass it then it
is against the documented interface.
If we are not sure and assume "in the wild" it might be used by many dag
authors inconsistently then the alternative would be to make the parameter on
the interface as optional and adding a pytest for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
