Ferdinanddb commented on PR #53455: URL: https://github.com/apache/airflow/pull/53455#issuecomment-3084400376
Hi, I won't have the capacity to test this PR in the coming days unfortunately or maybe during the weekend, but from what I can see: some unit tests have been added and that's great, but could you also add a unit test to verify the behavior when using the `ShortCircuitOperator` operator please? In my case (https://github.com/apache/airflow/issues/52869), I discovered the behavior while using the `ShortCircuitOperator` operator: my direct child task which was a sensor was not skipped while it should have been the case. My workaround was to add an `EmptyOperator` between my `ShortCircuitOperator` and my sensor, and then it worked as expected. Given this, do you think you could reproduce the bug? I am using a custom S3 sensor in my case, but I believe that it can be reproduce with every kind of sensors, including a basic one. Hope that it is clear, otherwise I tried to document everything back then in my issue (https://github.com/apache/airflow/issues/52869). Thank you for taking care of this :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
