jscheffl commented on code in PR #53407:
URL: https://github.com/apache/airflow/pull/53407#discussion_r2214058884
##########
providers/http/src/airflow/providers/http/hooks/http.py:
##########
@@ -172,7 +175,7 @@ def get_conn(
:return: A configured requests.Session object.
"""
session = Session()
- connection = self.get_connection(self.http_conn_id)
+ connection = self.get_connection(self.get_conn_id())
Review Comment:
I agree to this change. I do not understand why the hard coded
`<type>_conn_id` was actually made and what the benefit of this is/was. I
assume this is still from times of Python 2.x and is coming from Airflow
1.x-times. But this was from the past/legacy before I joined the project.
So would be cool asking some other committer with more history knowing a
reason why the current construct exists. I hope there is a reason behind and
not just a strange field design.
@potiuk @ashb @kaxil Do you know somebody from that point of history knowing
the reason behind this design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
