jscheffl commented on code in PR #53332: URL: https://github.com/apache/airflow/pull/53332#discussion_r2221102865
########## task-sdk-tests/tests/task_sdk_tests/constants.py: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import os +from pathlib import Path + +AIRFLOW_ROOT_PATH = Path(__file__).resolve().parents[3] + +DEFAULT_PYTHON_MAJOR_MINOR_VERSION = "3.10" +DEFAULT_DOCKER_IMAGE = f"ghcr.io/apache/airflow/main/prod/python{DEFAULT_PYTHON_MAJOR_MINOR_VERSION}:latest" +DOCKER_IMAGE = os.environ.get("DOCKER_IMAGE") or DEFAULT_DOCKER_IMAGE Review Comment: No, might be a mis-understanding. Did not want to add python coupling but removing here and adding as default parameter when calling and enforcing a parameter given when breeze runs the tests. But was just a suggestion to reduce the number of lines to change if we bump the minor Python version next year... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
