kyungjunleeme commented on code in PR #53597:
URL: https://github.com/apache/airflow/pull/53597#discussion_r2222989617
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py:
##########
@@ -36,10 +37,17 @@
responses=create_openapi_http_exception_doc([status.HTTP_400_BAD_REQUEST,
status.HTTP_401_UNAUTHORIZED]),
)
def create_token(
- body: LoginBody,
+ form_data: OAuth2PasswordRequestForm = Depends(),
Review Comment:
Thanks for pointing that out. You're right — since Airflow doesn't use
client_id, scope, or other OAuth2-related fields, it's not actually following
the OAuth2.0 spec.
I’ll update the /auth/token endpoint to align with how the Execution API
handles authentication — using JWTBearer and JWTBearerDep instead of relying on
OAuth2PasswordRequestForm.
Just to confirm: is the main reason we avoid calling this OAuth2 because we
don’t require client_id, scope, and similar parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
