o-nikolas commented on code in PR #53435:
URL: https://github.com/apache/airflow/pull/53435#discussion_r2223314682
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2016,7 +2017,7 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
extra=f"Task was requeued more than
{self._num_stuck_queued_retries} times and will be failed.",
)
)
- ti.set_state(TaskInstanceState.FAILED, session=session)
+ executor.fail(ti.key)
Review Comment:
> Interesting discussion :)
>
> What's the proposal then ?
>
> * ti.change state
>
> * followed by "fai" in executor ?
Yupp! If @karenbraganz can give that a test and ensure that solves the case
she's looking to solve then that would be my preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
