dstandish commented on code in PR #53475:
URL: https://github.com/apache/airflow/pull/53475#discussion_r2223683095
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -380,9 +381,8 @@ def create_pod(self, pod: V1Pod) -> V1Pod:
async def watch_pod_events(self, pod: V1Pod, check_interval: int = 1) ->
None:
"""Read pod events and writes into log."""
- self.keep_watching_for_events = True
num_events = 0
- while self.keep_watching_for_events:
+ while not self.stop_watching_events:
events = self.read_pod_events(pod)
Review Comment:
i don't think there's anything wrong with `while not stop`
see also
https://github.com/apache/airflow/blob/016b7cdb2995c62f4849a26acd6c15b6d8a6be95/airflow-core/src/airflow/jobs/triggerer_job_runner.py#L833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
