amoghrajesh commented on code in PR #53332: URL: https://github.com/apache/airflow/pull/53332#discussion_r2225448075
########## task-sdk-tests/pyproject.toml: ########## Review Comment: I thought of that initially, but it would be non essential because I want this to be a top level project and not under task-sdk essentially. Think similar to docker-tests. This will allow me to package and test in workflows. ########## task-sdk-tests/docker/docker-compose.yaml: ########## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +x-airflow-common: + &airflow-common + image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:3.0.3} + # image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:3.0.3} + environment: + &airflow-common-env + AIRFLOW__CORE__EXECUTOR: LocalExecutor + AIRFLOW__CORE__AUTH_MANAGER: airflow.providers.fab.auth_manager.fab_auth_manager.FabAuthManager + AIRFLOW__DATABASE__SQL_ALCHEMY_CONN: postgresql+psycopg2://airflow:airflow@postgres/airflow + AIRFLOW__CORE__FERNET_KEY: '' + AIRFLOW__CORE__LOAD_EXAMPLES: 'false' + AIRFLOW__CORE__EXECUTION_API_SERVER_URL: 'http://airflow-apiserver:8080/execution/' + user: "${AIRFLOW_UID:-50000}:0" + depends_on: + &airflow-common-depends-on + postgres: + condition: service_healthy + +services: + postgres: + image: postgres:13 + environment: + POSTGRES_USER: airflow + POSTGRES_PASSWORD: airflow + POSTGRES_DB: airflow + healthcheck: + test: ["CMD", "pg_isready", "-U", "airflow"] + interval: 10s + retries: 5 + start_period: 5s + restart: always + + airflow-init: + <<: *airflow-common + entrypoint: /bin/bash + command: + - -c + - | + echo "Creating missing opt dirs if missing:" + mkdir -v -p /opt/airflow/{logs,dags,plugins,config} + echo "Airflow version:" + /entrypoint airflow version + echo "Running airflow config list to create default config file if missing." + /entrypoint airflow config list >/dev/null + echo "Change ownership of files in /opt/airflow to ${AIRFLOW_UID}:0" + chown -R "${AIRFLOW_UID}:0" /opt/airflow/ + environment: + <<: *airflow-common-env + _AIRFLOW_DB_MIGRATE: 'true' + _AIRFLOW_WWW_USER_CREATE: 'true' + _AIRFLOW_WWW_USER_USERNAME: ${_AIRFLOW_WWW_USER_USERNAME:-airflow} + _AIRFLOW_WWW_USER_PASSWORD: ${_AIRFLOW_WWW_USER_PASSWORD:-airflow} + _PIP_ADDITIONAL_REQUIREMENTS: '' + user: "0:0" + depends_on: + <<: *airflow-common-depends-on + + airflow-apiserver: + <<: *airflow-common + command: api-server + ports: + - "8080:8080" + healthcheck: + test: ["CMD", "curl", "--fail", "http://localhost:8080/api/v2/version";] + interval: 30s + timeout: 10s + retries: 5 + start_period: 30s + restart: always + depends_on: + <<: *airflow-common-depends-on + airflow-init: + condition: service_completed_successfully + + airflow-scheduler: + <<: *airflow-common + entrypoint: /bin/bash + command: + - -c + - | + echo "Installing Task SDK version: ${TASK_SDK_VERSION:-1.1.0}" + pip install --no-deps apache-airflow-task-sdk==${TASK_SDK_VERSION:-1.1.0} Review Comment: Actually this part needn't be done at all i guess now that I think of it, the tests aren't running here but in the host. But, we are installing from current sources. ########## task-sdk-tests/tests/task_sdk_tests/constants.py: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import os +from pathlib import Path + +AIRFLOW_ROOT_PATH = Path(__file__).resolve().parents[3] + +DEFAULT_PYTHON_MAJOR_MINOR_VERSION = "3.10" +DEFAULT_DOCKER_IMAGE = f"ghcr.io/apache/airflow/main/prod/python{DEFAULT_PYTHON_MAJOR_MINOR_VERSION}:latest" +DOCKER_IMAGE = os.environ.get("DOCKER_IMAGE") or DEFAULT_DOCKER_IMAGE Review Comment: > I think what matters here is that you should be able to run the tests in local venv without breeze Precisely. I intend to have a way so that folks can run it either via breeze as well as from an venv. It will allow for local debugging and running from IDE too which I tried. Eg: 1. breeze testing task-sdk-integration-tests 2. source .venv/bin/activate & uv run python -m pytest task-sdk-tests/tests/task_sdk_tests/test_task_sdk_health.py -s --color=yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
