potiuk commented on code in PR #53149: URL: https://github.com/apache/airflow/pull/53149#discussion_r2225969164
########## task-sdk/src/airflow/sdk/timezone.py: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations Review Comment: My thinking was that the facade is not only for task-sdk, but we could also use it in "airflow-core" - so that we do no have to use "from airflow.sdk impor timezone" and "from airflow import timezone" in core - but yeah now when I think of that it should only be in "task-sdk" and indeed serve as e public api, so maintaining it manually is actually best approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
