amoghrajesh opened a new pull request, #53700:
URL: https://github.com/apache/airflow/pull/53700
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/pull/53627
On pondering over
https://github.com/apache/airflow/pull/53627#discussion_r2222001564, i came to
realise that I had misunderstood / not completely known that the
`per-file-ignores` ignores all the TID251 rules for the entries presented in it.
This is different from what I was trying to achieve there. It would lead to
low quality checks for banned API for the core files I intended to exclude from
the TID251 ruff rule.
What I wanted from the `per-file-ignores` entries:
✅ Allow from airflow.sdk import Task in these files
❌ Still block import unittest.TestCase in these files
❌ Still block logging.debug("msg") in these files
❌ Still block other deprecated/banned imports in these files
What I actually get:
✅ from airflow.sdk import Task → ignored (good)
❌ import unittest.TestCase → also ignored (bad!)
❌ logging.debug("msg") → also ignored (bad!)
❌ All other TID251 violations → also ignored (bad!)
Basically there's no way of achieveing: "In file x, ignore TID251 for
airflow.sdk imports but keep TID251 for unittest imports". Hence its not worth
the efforts invested when a `grep` like precommit can do it for me. Oh, and to
add: https://github.com/astral-sh/ruff/issues/14822, this will give us a rough
time probably intentionally / unintentionally.
How a failure looks like:
```
(airflow) ➜ airflow git:(precommit-to-disallow-sdk-imports-in-core) ✗
pre-commit run check-sdk-imports --all-files
Check for SDK imports in core
files......................................Failed
- hook id: check-sdk-imports
- exit code: 1
airflow-core/src/airflow/__init__.py:
Line 97: from airflow.sdk.definitions.asset import Asset, Dataset
Found 1 SDK import(s) in core files
```
As for the exclusions, we will get to it one-by-one as we progress with
client server separation.
**Performance wise, this pre-commit is slower (about 4x times) than ruff but
it is something we can live with!**
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
