sjyangkevin commented on code in PR #53690:
URL: https://github.com/apache/airflow/pull/53690#discussion_r2230037816
##########
airflow-core/tests/unit/serialization/serializers/test_serializers.py:
##########
@@ -250,7 +250,6 @@ def test_numpy_serializers(self):
("klass", "ver", "value", "msg"),
[
(np.int32, 999, 123, r"serialized version is newer"),
- (np.float32, 1, 123, r"unsupported numpy\.float32"),
Review Comment:
This test case is stale after removing the redundant type check in the
deserializers. Also, I notice `numpy.float32` is not in the serializers list,
but there is such a check. Not sure if it is an issue.
```python
if isinstance(o, (np.float16, np.float32, np.float64, np.complex64,
np.complex128)):
return float(o), name, __version__, True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
