pavansharma36 commented on code in PR #52662:
URL: https://github.com/apache/airflow/pull/52662#discussion_r2231119687
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -530,7 +530,11 @@ def terminate(self) -> None:
self.log.debug("Terminating kube_watchers...")
for kube_watcher in self.kube_watchers.values():
kube_watcher.terminate()
- kube_watcher.join()
+ kube_watcher.join(timeout=60)
Review Comment:
@potiuk made suggested changes
we deployed fix in prod and haven't noticed issue afterwards
BTW its max of MAX_WAITING_TIME-(current_time()-start_time),0 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
