gopidesupavan commented on code in PR #53647:
URL: https://github.com/apache/airflow/pull/53647#discussion_r2233971148
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -590,7 +591,7 @@ def __init__(
"""Initialize the hook instance."""
self.conn_id = wasb_conn_id
self.public_read = public_read
- self.blob_service_client: AsyncBlobServiceClient = None # type: ignore
+ self.blob_service_client: AsyncBlobServiceClient | None = None #
type: ignore
Review Comment:
this is cached_property, we should not set directly any values to them, its
better to use setters. could you please re-work on assignment of
`self.blob_service_client` likely you need to implement setter in WasbHook and
use that setter.
you can update these changes in different PR. so please remove this file
changes from this PR and rest all LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
