sjyangkevin commented on code in PR #53690:
URL: https://github.com/apache/airflow/pull/53690#discussion_r2238425770
##########
airflow-core/tests/unit/serialization/test_serde.py:
##########
@@ -61,6 +63,49 @@ def recalculate_patterns():
_match_regexp.cache_clear()
+def generate_serializers_importable_and_str_test_cases():
Review Comment:
>A skip means that you expect your test to pass only if some conditions are
met, otherwise pytest should skip running the test altogether.
I revisited the document and seems like skip is a better option. In this
case, I would expect the `np.bool` case to pass if the installed NumPy version
is above 2.0.
>Why not just mark the bool case instead, not the entire test?
I wanted to understand it better in terms of the implementation. Do you
suggest to replace the `pytest.xfail` in the commit
https://github.com/apache/airflow/commit/5735f6b4aa7efd83113089a87a553c663d6e1f4a
with `pytest.skip`? Or I should restructure it to individual tests (i.e.,
`np.bool` has its own test case) and use `pytest.mark.skipif` for that test
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
