guan404ming commented on code in PR #53035: URL: https://github.com/apache/airflow/pull/53035#discussion_r2240439139
########## airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx: ########## @@ -0,0 +1,195 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Badge, Link } from "@chakra-ui/react"; +import type { ColumnDef } from "@tanstack/react-table"; +import type { TFunction } from "i18next"; +import { useTranslation } from "react-i18next"; +import { Link as RouterLink, useParams } from "react-router-dom"; + +import { useHumanInTheLoopServiceGetHitlDetails } from "openapi/queries"; +import type { HITLDetail } from "openapi/requests/types.gen"; +import { DataTable } from "src/components/DataTable"; +import { useTableURLState } from "src/components/DataTable/useTableUrlState"; +import { ErrorAlert } from "src/components/ErrorAlert"; +import { StateBadge } from "src/components/StateBadge"; +import Time from "src/components/Time"; +import { TruncatedText } from "src/components/TruncatedText"; +import { useAutoRefresh } from "src/utils"; +import { getTaskInstanceLink } from "src/utils/links"; + +type TaskInstanceRow = { row: { original: HITLDetail } }; + +const statusMapping = (translate: TFunction, operator: string, responseReceived: boolean) => { + const statusMap = { + ApprovalOperator: ["approvalRequired", "approvalReceived"], + HITLBranchOperator: ["choiceRequired", "choiceReceived"], + HITLEntryOperator: ["inputRequired", "inputReceived"], + HITLOperator: ["responseRequired", "responseReceived"], + }; + + const [required, received] = statusMap[operator as keyof typeof statusMap]; + + return translate(`hitl:status.${responseReceived ? received : required}`); +}; + +const taskInstanceColumns = ({ + dagId, + runId, + taskId, + translate, +}: { + dagId?: string; + runId?: string; + taskId?: string; + translate: TFunction; +}): Array<ColumnDef<HITLDetail>> => [ + { + accessorKey: "task_instance.operator", + cell: ({ row: { original } }: TaskInstanceRow) => { + const { operator } = original.task_instance; + + return <Badge>{statusMapping(translate, operator ?? "", original.response_received ?? false)}</Badge>; + }, + header: translate("Status"), + }, + { + accessorKey: "subject", + cell: ({ row: { original } }: TaskInstanceRow) => ( + <Link asChild color="fg.info" fontWeight="bold"> + <RouterLink to={`${getTaskInstanceLink(original.task_instance)}/action_required`}> + <TruncatedText text={original.subject} /> + </RouterLink> + </Link> + ), + header: translate("Subject"), + }, + ...(Boolean(dagId) + ? [] + : [ + { + accessorKey: "task_instance.dag_id", + enableSorting: false, + header: translate("dagId"), + }, + ]), + ...(Boolean(runId) + ? [] + : [ + { + accessorKey: "run_after", + // If we don't show the taskId column, make the dag run a link to the task instance + cell: ({ row: { original } }: TaskInstanceRow) => + Boolean(taskId) ? ( + <Link asChild color="fg.info" fontWeight="bold"> + <RouterLink to={getTaskInstanceLink(original.task_instance)}> + <Time datetime={original.task_instance.run_after} /> + </RouterLink> + </Link> + ) : ( + <Time datetime={original.task_instance.run_after} /> + ), + header: translate("dagRun_one"), + }, + ]), + ...(Boolean(taskId) + ? [] + : [ + { + accessorKey: "task_display_name", + cell: ({ row: { original } }: TaskInstanceRow) => ( + <TruncatedText text={original.task_instance.task_display_name} /> + ), + enableSorting: false, + header: translate("taskId"), + }, + ]), + { + accessorKey: "rendered_map_index", + header: translate("mapIndex"), + }, + { + accessorKey: "state", + cell: ({ + row: { + original: { + task_instance: { state }, + }, + }, + }) => <StateBadge state={state}>{translate(`common:states.${state}`)}</StateBadge>, + header: () => translate("state"), + }, + { + accessorKey: "response_received", + header: translate("Response Received"), + }, + { + accessorKey: "response_at", + cell: ({ row: { original } }) => <Time datetime={original.response_at} />, + header: translate("Response At"), + }, +]; + +export const HITLTaskInstances = () => { + const { t: translate } = useTranslation(); + const { dagId, groupId, runId, taskId } = useParams(); + const { setTableURLState, tableURLState } = useTableURLState(); + const { pagination } = tableURLState; + + const refetchInterval = useAutoRefresh({}); + + const { data, error, isLoading } = useHumanInTheLoopServiceGetHitlDetails( + { + dagIdPattern: dagId, + dagRunId: runId, + }, + undefined, + { + enabled: !isNaN(pagination.pageSize), + refetchInterval, + }, + ); + + const filteredData = data?.hitl_details.filter((hitl) => { + if (taskId !== undefined) { + return hitl.task_instance.task_id === taskId; + } else if (groupId !== undefined) { + return hitl.task_instance.task_id.includes(groupId); + } + + return true; + }); + + return ( + <DataTable + columns={taskInstanceColumns({ + dagId, + runId, + taskId: Boolean(groupId) ? undefined : taskId, + translate, + })} + data={filteredData ?? []} + errorMessage={<ErrorAlert error={error} />} + initialState={tableURLState} + isLoading={isLoading} + modelName={translate("common:taskInstance_other")} Review Comment: It is wrong. Let me correct it with right name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
