jscheffl commented on code in PR #54077: URL: https://github.com/apache/airflow/pull/54077#discussion_r2252423099
########## providers/edge3/docs/edge_executor.rst: ########## @@ -50,6 +50,11 @@ could take thousands of tasks without a problem), or from an environment perspective (you want a worker running from a specific location where required infrastructure is available). +When using EdgeExecutor in addition to other executors and EdgeExecutor not being the default executor +(that is to say the first one in the list of executors), be reminded to also define EdgeExecutor Review Comment: You have a tailing-space problem which makes the static checks fail. ```suggestion (that is to say the first one in the list of executors), be reminded to also define EdgeExecutor ``` ########## providers/edge3/docs/edge_executor.rst: ########## @@ -50,6 +50,11 @@ could take thousands of tasks without a problem), or from an environment perspective (you want a worker running from a specific location where required infrastructure is available). +When using EdgeExecutor in addition to other executors and EdgeExecutor not being the default executor +(that is to say the first one in the list of executors), be reminded to also define EdgeExecutor +as the executor at task or dag level in addition to the queues you are targeting. + Review Comment: Maybe adding a link? ```suggestion For more details on multiple executors please see :ref:`apache-airflow:using-multiple-executors-concurrently`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
