sjyangkevin commented on PR #54043: URL: https://github.com/apache/airflow/pull/54043#issuecomment-3152777551
Thanks everyone's time on reviewing this PR. I've made the following updates to resolve the compatibility test failures. 1. I've done some clean up since most of the changes have been added in https://github.com/apache/airflow/pull/53035. 2. The compat check is resolved by the following two steps 1.) register `DagAccessEntity.HITL_DETAIL` only when Airflow version is greater than or equal to 3.1.0 in fab auth manager 2.) create a set of tests and only import/run those when Airflow version is greater than or equal to 3.1.0. @Lee-W , @pierrejeambrun , @vincbeck , and @jason810496 feel free to let me know if you have further feedback. I also did some manual functional tests by running Airflow with HITL example DAG. First, I defined the following roles and assign the roles to the `test` user. <img width="1341" height="191" alt="Screenshot from 2025-08-04 17-33-32" src="https://github.com/user-attachments/assets/b14126dc-2804-4205-84f5-9a6c993e320c"; /> <img width="1366" height="333" alt="Screenshot from 2025-08-04 17-33-13" src="https://github.com/user-attachments/assets/72e93a2b-6b62-4fdb-b960-89f021ce7aee"; /> With `HITL_Viewer` role, the user can only access those `GET` endpoints but cannot access `PATCH` endpoints, as shown below. ### Test access to an GET endpoint <img width="1384" height="782" alt="Screenshot from 2025-08-04 17-31-40" src="https://github.com/user-attachments/assets/437d4550-0c31-499a-bb1f-f1785617690d"; /> ### Test access to a PATCH endpoint <img width="1411" height="703" alt="Screenshot from 2025-08-04 17-32-25" src="https://github.com/user-attachments/assets/800aee9c-5ea8-4db2-982b-447b2a105279"; /> ### Test access to a PATCH endpoint With `HITL_Editor` role, the user's access to `PATCH` endpoints will not be forbidden. <img width="1417" height="672" alt="Screenshot from 2025-08-04 17-32-59" src="https://github.com/user-attachments/assets/ef66e26a-ca3a-4a82-a88a-94f9cc8fb058"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
