xBis7 commented on code in PR #53722: URL: https://github.com/apache/airflow/pull/53722#discussion_r2254693193
########## providers/edge3/src/airflow/providers/edge3/version_compat.py: ########## @@ -33,3 +33,15 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]: AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0) +AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0) + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import BaseOperator +else: + from airflow.models import BaseOperator + +__all__ = [ + "AIRFLOW_V_3_0_PLUS", + "AIRFLOW_V_3_1_PLUS", + "BaseOperator", +] Review Comment: I get the idea but we still need ``` AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0) ``` in order to check whether to use the `DualStatsManager` or the original code. Otherwise there are compatibility issues because the `DualStatsManager` doesn't exist in older providers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
