Dev-iL commented on code in PR #54065:
URL: https://github.com/apache/airflow/pull/54065#discussion_r2256626305
##########
airflow-core/tests/unit/cli/commands/test_dag_command.py:
##########
@@ -250,22 +250,22 @@ def test_cli_get_dag_details(self):
assert value in out
@conf_vars({("core", "load_examples"): "true"})
- def test_cli_list_dags(self):
+ def test_cli_list_dags(self, stdout_capture):
args = self.parser.parse_args(["dags", "list", "--output", "json"])
- with contextlib.redirect_stdout(StringIO()) as temp_stdout:
+ with stdout_capture as temp_stdout:
dag_command.dag_list_dags(args)
out = temp_stdout.getvalue()
dag_list = json.loads(out)
- for key in ["dag_id", "fileloc", "owners", "is_paused"]:
+ for key in ["dag_id", "fileloc", "owners", "is_paused"]: #
"bundle_name", "bundle_version"?
Review Comment:
This comment is correct. However, I'd like to keep the comment as a reminder
that we need a test that checks for those fields as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
