pierrejeambrun commented on code in PR #54166:
URL: https://github.com/apache/airflow/pull/54166#discussion_r2257546983
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -151,20 +151,25 @@ export const HITLTaskInstances = () => {
});
return (
- <DataTable
- columns={taskInstanceColumns({
- dagId,
- runId,
- taskId: Boolean(groupId) ? undefined : taskId,
- translate,
- })}
- data={filteredData ?? []}
- errorMessage={<ErrorAlert error={error} />}
- initialState={tableURLState}
- isLoading={isLoading}
- modelName={translate("hitl:requiredAction_other")}
- onStateChange={setTableURLState}
- total={filteredData?.length}
- />
+ <Box>
+ {!Boolean(dagId) && !Boolean(runId) && !Boolean(taskId) ? (
+ <Heading size="md">{translate("hitl:requiredAction_other")}</Heading>
Review Comment:
You can use the `count` param of the `translate` function to automatically
chose `_one` or `_other` depending on the value.
```
<Heading py={3} size="md">
{data?.total_entries} {translate("common:asset", { count:
data?.total_entries })}
</Heading>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
