vizeit commented on code in PR #54041:
URL: https://github.com/apache/airflow/pull/54041#discussion_r2257952636
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -62,7 +62,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator,
KubernetesPodOperator):
# `cmds` and `arguments` are used internally by the operator
template_fields: Sequence[str] = tuple(
- {"op_args", "op_kwargs", *KubernetesPodOperator.template_fields} -
{"cmds", "arguments"}
+ sorted({"op_args", "op_kwargs",
*KubernetesPodOperator.template_fields} - {"cmds", "arguments"})
Review Comment:
K8 pod operator or any operator using tuple to defined template fields will
have deterministic order. The problem is, as detailed in the issue, when a set
is used to create template fields where the order is non-deterministic e.g. K8
decorator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
