dejii commented on code in PR #54101:
URL: https://github.com/apache/airflow/pull/54101#discussion_r2258916486
##########
providers/google/src/airflow/providers/google/cloud/triggers/cloud_storage_transfer_service.py:
##########
@@ -87,13 +88,9 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
for job, operation in zip(jobs, operations):
if operation is None:
- yield TriggerEvent(
- {
- "status": "error",
- "message": f"Transfer job {job.name} has no
latest operation.",
- }
- )
- return
+ self.log.info("Transfer job %s has no latest operation
yet, waiting.", job.name)
+ all_operations_found = False
+ continue
Review Comment:
Also, I’m not sure if adding a fixed number of retries would be ideal here,
since the trigger is stateless. It might be more appropriate to use a
timeout-based approach for waiting on the operation, and we could make that
timeout configurable. This way, the start time and operation timeout seconds
can be serialized by the trigger, ensuring consistent behavior across
interruptions or restarts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
