Asquator commented on PR #53492:
URL: https://github.com/apache/airflow/pull/53492#issuecomment-3162666876

   I think @dstandish has a point here. In the beginning we planned to make 
four flat windows, but it was decided to nest them, and now I think for no 
reason at all. As the window values (row_numbers, sums) are assigned after 
partitioning is done, consistency and scheduling guarantees should be achieved. 
I will fix it ASAP to measure performance again, since now it's pretty slow, 
and the plan looks intimidating.
   
   Regarding the two windows that look similar - I doubt they can be replaced 
by one window due to different _partition by_ columns.
   
   Thanks for looking at the join conditions. I'll try to fix them too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to