guan404ming commented on code in PR #54195:
URL: https://github.com/apache/airflow/pull/54195#discussion_r2259384743
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py:
##########
@@ -98,7 +100,7 @@ class SqlToS3Operator(BaseOperator):
template_fields_renderers = {
"query": "sql",
"pd_kwargs": "json",
Review Comment:
It works similarly for both libraries, but the naming isn’t ideal. I think
renaming it to df_kwargs would be better. I'll keep `pd_kwargs` as well for
backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
