guan404ming commented on code in PR #54187:
URL: https://github.com/apache/airflow/pull/54187#discussion_r2259413807
##########
providers/amazon/tests/unit/amazon/aws/transfers/test_sql_to_s3.py:
##########
@@ -64,7 +64,7 @@ def test_execute_csv(self, mock_s3_hook, dtype_backend):
file_obj =
mock_s3_hook.return_value.load_file_obj.call_args[1]["file_obj"]
assert isinstance(file_obj, io.BytesIO)
mock_s3_hook.return_value.load_file_obj.assert_called_once_with(
- file_obj=file_obj, key=s3_key, bucket_name=s3_bucket, replace=True
+ file_obj=file_obj, key=f"{s3_key}.csv", bucket_name=s3_bucket,
replace=True
Review Comment:
We could consider using `@pytest.mark.parametrize` to reduce code
duplication and improve maintainability since lots of the test looks similar
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
