ashb commented on code in PR #54216:
URL: https://github.com/apache/airflow/pull/54216#discussion_r2259872207
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -753,7 +753,8 @@ def generate_run_id(
"""
# _Ensure_ run_type is a DagRunType, not just a string from user code
if logical_date:
- return
DagRunType(run_type).generate_run_id(suffix=run_after.isoformat())
+ #To ensure that the logicak_date aligns with the naming of run_id
+ return
DagRunType(run_type).generate_run_id(suffix=logical_date.isoformat())
Review Comment:
The issue with doing this is that logical_date is not unique, and so this
could end up failing to create with a UniqueConstraintViolation error.
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
